Skip to content

[SOS/DAC] Add tests for DAC GC bugs #5562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 26, 2025
Merged

[SOS/DAC] Add tests for DAC GC bugs #5562

merged 16 commits into from
Sep 26, 2025

Conversation

@max-charlamb
Copy link
Member

@max-charlamb max-charlamb commented Sep 5, 2025 •
edited
Loading

@max-charlamb max-charlamb requested a review from a team as a code owner September 5, 2025 20:43
@max-charlamb max-charlamb mentioned this pull request Sep 5, 2025
Merged
@davidwrighton
Copy link
Member

davidwrighton commented Sep 5, 2025

I believe we need to have a scheme to disable this test for versions of the runtime older than .NET 11 (unless of course you intend to fix this in downlevel versions), but this looks generally ok to me.

@steveisok
Copy link
Member

steveisok commented Sep 5, 2025

I believe we need to have a scheme to disable this test for versions of the runtime older than .NET 11 (unless of course you intend to fix this in downlevel versions), but this looks generally ok to me.

diagnostics/src/SOS/SOS.UnitTests/SOS.cs

Line 206 in a853665

if (config.RuntimeFrameworkVersionMajor < 10)
is an example of how to pull that off.

@max-charlamb max-charlamb changed the title [SOS/DAC] Add test for DumpGCData [SOS/DAC] Add tests for DAC GC bugs Sep 8, 2025
@max-charlamb max-charlamb mentioned this pull request Sep 8, 2025
Merged
@max-charlamb max-charlamb mentioned this pull request Sep 8, 2025
Merged
4 tasks
noahfalk
noahfalk previously approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Comments inline where I'm hoping we can simplify the config pattern.

@max-charlamb max-charlamb mentioned this pull request Sep 9, 2025
Merged
4 tasks
max-charlamb
max-charlamb commented Sep 9, 2025
View reviewed changes
src/Microsoft.Diagnostics.ExtensionCommands/RootCacheService.cs
Comment on lines +43 to 45
InitializeHandleRoots();

int i = _dependentHandles.BinarySearch((source, target));
Copy link
Member Author

@max-charlamb max-charlamb Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this bug while working on the tests. In some cases, this is not initialized before referencing.

noahfalk
noahfalk previously approved these changes Sep 9, 2025
View reviewed changes
@max-charlamb max-charlamb mentioned this pull request Sep 25, 2025
Merged
@max-charlamb max-charlamb merged commit 17279a6 into main Sep 26, 2025
19 checks passed
@max-charlamb max-charlamb deleted the add-dumpgcdata-test branch September 26, 2025 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@tommcdon tommcdon tommcdon approved these changes

@noahfalk noahfalk Awaiting requested review from noahfalk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@max-charlamb @davidwrighton @steveisok @noahfalk @tommcdon